https://bugzilla.redhat.com/show_bug.cgi?id=1856557 --- Comment #3 from Mat Booth <mat.booth@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #2) > Taking this review. > > One blocking issue right away: The latest version seems to be 217.21, the > package is for 217.8 right now. Can you update it to the latest version? > https://github.com/jenkinsci/trilead-ssh2/releases > Err... Probably. "8" is the last version before they added deps on stuff not in Fedora > Also, the versioning scheme is very weird here (both upstream and in the > package). > Maybe do something like this instead? The "patch level" definitely shouldn't > be in the Release tag. I'd say that ".jenkins" shouldn't be part of the > Release tag, either, since it has nothing to do with the versioning, but > with the origin of the sources. > Yeah that's fair > > A comment in the .spec file that the package is built from the Jenkins fork > of trilead-ssh2 (and why?) is enough. Comment added See updated spec file: Spec URL: https://fedorapeople.org/~mbooth/reviews/trilead-ssh2.spec SRPM URL: https://fedorapeople.org/~mbooth/reviews/trilead-ssh2-217.21-14.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
