https://bugzilla.redhat.com/show_bug.cgi?id=1856552 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |decathorpe@xxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- One small issue: Please use https links for Source1 (maven central isn't even reachable via plain http any longer). I'm not sure if sourceforge provides https links for downloads, but if it does, please use https for Source0 as well. Otherwise, looks good. Pretty standard Java packaging stuff in here ... The package also has correct upgrade path over all previously available versions. Be aware that if you want to reintroduce the package on some non-modular branch other than rawhide, you'll have to request f32 / f31 branches after the unretirement request went through (since jchardet was retired before the f31 branch point). Package APPROVED (but please fix the Source0/1 HTTPS URL before importing). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
