https://bugzilla.redhat.com/show_bug.cgi?id=1856464 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - It is not needed: %{?systemd_requires} BuildRequires: systemd Instead depend on: BuildRequires: systemd-rpm-macros - Patch0: ufdbGuard-common.patch Add a comment explaining why the patch is needed. - Not needed: %install rm -rf %{buildroot} ← - Please use macros for directories: %configure \ --with-ufdb-user=ufdb \ --prefix=%{_prefix} \ --with-ufdb-bindir=%{_sbindir} \ --with-ufdb-piddir=%{_localstatedir}/run/ufdbguard \ --with-ufdb-mandir=%{_mandir} \ --with-ufdb-images_dir=%{_sharedstatedir}/ufdbguard/images \ --with-ufdb-logdir=%{_localstatedir}/log/ufdbguard \ --with-ufdb-samplesdir=%{_sharedstatedir}/ufdbguard/samples \ --with-ufdb-config=%{_sysconfdir}/ufdbguard \ --with-ufdb-dbhome=%{_sharedstatedir}/ufdbguard/blacklists \ --with-ufdb-imagesdir=%{_sharedstatedir}/ufdbguard/images - %{__make} %{?_smp_mflags} → %make_build - %{__make} DESTDIR=%{buildroot} mkdirsredhatcentos install → %make_install mkdirsredhatcentos - Don't use macros starting with __, they are for RPM private use, use the normal binaries: for i in $(find doc/ -type f -name '*.1'); do install -p -D -m 0644 $i %{buildroot}%{_mandir}/man1/ done for i in $(find doc/ -type f -name '*.8'); do install -p -D -m 0644 $i %{buildroot}%{_mandir}/man8/ done install -p -D -m 0644 %{SOURCE1} $RPM_BUILD_ROOT%{_unitdir}/ufdbGuard.service install -p -D -m 0644 %{SOURCE2} $RPM_BUILD_ROOT%{_sysconfdir}/logrotate.d/ufdbGuard - Don't mix both $RPM_BUILD_ROOT and %{buildroot}, standardize on one - Macros again: %dir %{_sharedstatedir}/ufdbguard/ %attr(-, ufdb, ufdb) %dir %{_localstatedir}/log/ufdbguard/ %{_sharedstatedir}/ufdbguard/* -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
