Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Object-Deadly - An object that dies whenever examined https://bugzilla.redhat.com/show_bug.cgi?id=351611 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-26 01:51 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url fcf2895dd63b4bdd3a9ad683516b7aef Object-Deadly-0.09.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01pod.............skipped all skipped: Skipping author tests t/02pod-coverage....skipped all skipped: Skipping author tests t/03yaml............skipped all skipped: Skipping author tests t/04boilerplate.....skipped all skipped: Skipping author tests t/10load............# Testing Object::Deadly 0.09, Perl 5.008008, /usr/bin/perl ok t/20deadly..........ok t/21class...........ok All tests successful, 4 tests skipped. Files=7, Tests=139, 1 wallclock secs ( 0.36 cusr + 0.06 csys = 0.42 CPU) + Package perl-Object-Deadly-0.09-2.fc8 -> Provides: perl(Object::Deadly) = 0.09 perl(Object::Deadly::_safe) perl(Object::Deadly::_unsafe) Requires: perl(:MODULE_COMPAT_5.8.8) perl(B) perl(Carp::Clan) >= 5.4 perl(Devel::Symdump) perl(English) perl(Object::Deadly) perl(Object::Deadly::_safe) perl(Object::Deadly::_unsafe) perl(Scalar::Util) perl(overload) perl(strict) perl(vars) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review