Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl-Date-Calc https://bugzilla.redhat.com/show_bug.cgi?id=226249 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-26 01:42 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 7ae34972694127e8f1c9a2af1c24585b Date-Calc-5.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful. Files=48, Tests=2770, 3 wallclock secs ( 2.20 cusr + 0.35 csys = 2.55 CPU) + Package perl-Date-Calc-5.4-3.fc8 -> Provides: Calc.so perl(Date::Calc::Object) = 5.4 perl(Date::Calendar) = 5.4 perl(Date::Calendar::Profiles) = 5.4 perl(Date::Calendar::Year) = 5.4 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) perl(:MODULE_COMPAT_5.8.8) perl(Bit::Vector) perl(Bit::Vector) >= 6.4 perl(Carp::Clan) perl(Date::Calc::Object) perl(Date::Calendar::Year) perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) rtld(GNU_HASH) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review