Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: conntrack-tools - Tools to manipulate netfilter connection tracking table https://bugzilla.redhat.com/show_bug.cgi?id=339961 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-26 01:32 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url c639e17ba6cbfce52b288a5105724f2d conntrack-tools-0.9.5.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package conntrack-tools-0.9.5-3.fc8 -> Provides: conntrack = 1.0-1 Requires: /bin/sh libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libnetfilter_conntrack.so.1 libnfnetlink.so.0 libpthread.so.0 libpthread.so.0(GLIBC_2.0) rtld(GNU_HASH) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review