Product: Fedora Version: rawhide Component: Package Review Thomas Sailer <t.sailer@xxxxxxxxxxxxxx> has canceled Package Review <package-review@xxxxxxxxxxxxxxxxxxxxxxx>'s request for Thomas Sailer <t.sailer@xxxxxxxxxxxxxx>'s needinfo: Bug 1673956: Review Request: octave-openems - An electromagnetic field solver for octave https://bugzilla.redhat.com/show_bug.cgi?id=1673956 --- Comment #4 from Thomas Sailer <t.sailer@xxxxxxxxxxxxxx> --- Hi Hirotaka, thanks for the review! Macro expanded in comment: thanks for spotting this, will fix. dangerous-command-in-%preun: this is due to a macro defined in package octave-devel; it should be addressed there if at all shared-lib-calls-exit: somewhat unfortunate, but this is only used in critical error conditions to abort, so I don't think it is a problem no-manual-page-for-binary: man pages are not mandatory; a man page for a gui program that takes no options whatsoever does not provide a lot of value; the other binaries are not intended to be used directly, but rather are used as helper binaries by the octave packages no-documentation: this is a shortcoming of rpmlint; the documentation is part of the octave package, it will be shown in octave with for example pkg describe openems license: I missed the LGPLv3, thanks for catching this; I've added the license breakdown consistent use of macros: can you please point out where you see inconsistencies? source url: I don't understand the issue, git describe --tags | sed -e s,-,_, should be the same as v%{version}%{extraversion} %{octpkgdir}/private: that seems to be an issue with the macros in octave-devel... https://sailer.fedorapeople.org/octave-openems-0.0.35-1.fc33.src.rpm https://sailer.fedorapeople.org/octave-openems.spec https://copr.fedorainfracloud.org/coprs/sailer/radiofrequency/build/1544079/ _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
