https://bugzilla.redhat.com/show_bug.cgi?id=1853888 --- Comment #5 from Lewis <anesa.lewis@xxxxxxxxx> --- Hi Robert-André Mauchin, really glad to see you there! "- Feel free to converse in French if needed." ok, everything I'm not sure to say the right way will be written in french. > - Source must point to the upstream archive URL > > Source: %{name}-%{version}.tar.gz The line you paste there, what do you really expect? (same url as in "URL:"?) > - https://codecolla.com:10734/ doesn't resolve for me. Where to get the source code *officially*? Vraiement officiellement? c'est hébergé sur une raspberry pi chez moi et accessible en git uniquement pour le moment : git clone git://codecolla.com/libltk Je compte à termes y mettre un serveur http pour suivre l'évolution des projets, deployer, tester, démontrer, etc... En attendant je pourrais fournir https://copr.fedorainfracloud.org/coprs/lewisanesa/CodeColla/ comme URL non? > - Please remove the gz extension for man page in %files and use a glob * instead, as compression may change in the future. J'enlève .gz dans les fichiers, les commandes gzip, mais ne dois-je pas les remplacer par d'autres commandes? Sinon, comment rpm build sait où trouver les man pages dans mes sources? > - Why do you repeat: mkdir -p %{buildroot}%{_mandir}/man3 several times? It only needs to be created once. Try simplify the copy code too Le spec file est auto généré avec un script, il me faut encore travailler dessus. Vous le trouverez à la racine du projet git au nom de make.sh . > - includes go to the devel package > - The unversioned library goes to devel subpackage too > - %build %set_build_flags %make_build NAME=%{name} VERSION=%{version} Done. > - install -m 755 -D bin/lib%{name}.so %{buildroot}%{_libdir}/lib%{name}.so.%{version} > This is not sufficient to set a SONAME, it's just create a link. Setting a soname is mandatory in Fedora, generally ask upstream to do it, or if they refuse, add it to your Fedora package. Le upstream ne risque pas de refuser, puisque c'est moi. Je suis seul et unique a ravailler sur ce projet et je veux coller aux specs de fedora. Je vais faire ça : gcc -shared -fPIC -Wl,-soname,libfoo.so.1 -o libfoo.so.1.0.0 foo.c Mais mettre des virgules dans une commande de compilation me semble étrange. For non french speaking people, I'll recap changes made to fit fedora requirements, may this help someone one day... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
