[Bug 1853858] Review Request: badwolf - Web Browser which aims at security and privacy over usability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1853858



--- Comment #2 from Lyes Saadi <fedora@xxxxxxx> ---
Hello :D!

Sorry for the mistakes, I should've self-reviewed the package before submitting
it.

Spec URL: https://lyessaadi.fedorapeople.org/badwolf/badwolf.spec

SRPM URL:
https://lyessaadi.fedorapeople.org/badwolf/badwolf-1.0.0-2.fc32.src.rpm

Copr Build:
https://copr.fedorainfracloud.org/coprs/lyessaadi/badwolf/build/1527169/
Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=46760118

>  - There are some shenanigans with lang directories not being owned but I don't know what's the problem with the script. I've tried this:
>
> %find_lang Badwolf 
> echo "%%dir %%{_datadir}/%%{name}/locale" >> Badwolf.lang
> for l in locale/*;
> do
>   echo "%%dir %%{_datadir}/%%{name}/$l"
>   echo "%%dir %%{_datadir}/%%{name}/$l/LC_MESSAGES"
> done >> Badwolf.lang

I really liked your approach for solving this!

After trying some more things, I found that this apparently also worked:

> %dir %{_datadir}/%{name}/locale
> %dir %{_datadir}/%{name}/locale/*
> %dir %{_datadir}/%{name}/locale/*/LC_MESSAGES

I used it in the new version of the spec! What do you think?
Both seem to work fine, and I don't really have any preference for one or
another.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux