[Bug 1845667] Review Request: qxmledit - Powerful XML editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1845667



--- Comment #4 from Eugene A. Pivnev <ti.eugene@xxxxxxxxx> ---
(In reply to Robert-André Mauchin 🐧 from comment #3)
>  - gzip install_scripts/environment/man/%{name}.1
> 
> Do not gzip the manpage yourself, it is handled by RPM
> 
>  - Do not use .gz extension for man page as the compression may change in
> the future, use a glob instead:
> 
> %{_mandir}/man1/%{name}.1.*

Fixed.

>  - libraries should be installed with 0755. It is needed for them to be
> stripped and detected as a Provides.
> 
> %attr(0644,-,-) %{_libdir}/libQXmlEdit{Sessions,Widget}.so.*

Fixed.

>  - This was not fixed as intended:
> 
> >  - In order to avoid unintentional soname bump, we recommend not globbing
> > the major soname version, instead be more specific:
> > 
>   The major soname version is 0, so unglob that part:
> 
> %{_libdir}/libQXmlEdit*.so.0*

Fixed.

====
SPEC: https://tieugene.fedorapeople.org/rpms/qxmledit/qxmledit.spec
(old SPEC:
https://tieugene.fedorapeople.org/rpms/qxmledit/qxmledit-0.9.15.2.spec)
SRPM:
https://tieugene.fedorapeople.org/rpms/qxmledit/qxmledit-0.9.15-3.fc32.src.rpm
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=46737986


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux