Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ds9 - Astronomical Data Visualization Application https://bugzilla.redhat.com/show_bug.cgi?id=352761 ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-10-25 14:19 EST ------- A couple of quick comments: You should use %{__ln_s} in %build since you use macroized versions of the other commands. If you don't need to update the icon cache, it's probably best to remove the comments from your %post and %postun scriptlets and use the %post -p /sbin/ldconfig form instead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review