Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tkimg - More Image Formats for Tk https://bugzilla.redhat.com/show_bug.cgi?id=352741 mmahut@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mmahut@xxxxxxxxxx Status|NEW |NEEDINFO Flag| |needinfo?(sergio.pasra@gmail | |.com) ------- Additional Comments From mmahut@xxxxxxxxxx 2007-10-25 14:18 EST ------- [-] source files match upstream: 07afc28f7e1149dad65471f387298052 tkimg-1.3.tar.gz 964a692db8a120dc5ed8779521a70bc8 tkimg-1.3.tar.gz.upstream * I diffed the tree and I see no changes beside owership. Please make sure you ship the version from sourcefource page. [+] package meets naming and versioning guidelines. [+] specfile is properly named and cleanly written. [-] dist tag is present. * Please use dist tag for your release tag. http://fedoraproject.org/wiki/Packaging/DistTag [+] build root is correct. %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) [+] license field matches the actual license. [+] license is open source-compatible. [+] latest version is being packaged. [+] BuildRequires are proper. [+] rpmlint is silent. [+] no duplicates in %files. [+] file permissions are appropriate. [+] compiler flags are appropriate. [+] %clean is present. [+] package builds in mock (rawhide). [+] package installs properly. Please, fix these two errors and provide me with new spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review