https://bugzilla.redhat.com/show_bug.cgi?id=1853888 --- Comment #2 from Lewis <anesa.lewis@xxxxxxxxx> --- Lyes, thanks for your review and yes I'm new, and I'm also a newbie in packaging. Here is the new version of the project : https://filebin.net/9txmvp0wqo1jn6tq You'll notice that work is still in progress. Back to things you pointed : 2. 6. 7. 8. 9. 11. Treated but surely need review. 1. Project was hosted on github a long time ago : https://github.com/Pixelec/OSPOOC. But since github moved in the hands of microsoft, I don't find this place trust worthy anymore. codecolla.com is meant to become a tiny forge hosting project and their developpment. It actually hosts a git server but no http server yet. I'm not comfortable with the idea of add a project to a forge to remove it some months later. Furthermore, it looks like fedora community hosts a git repo, with bugzilla, what a place of choice for project that target only this distribution... May I set the URL to a git URL, looks like no, only web site expected. But anyway, tell me if it's mandatory and I'll move it to nongnu savannah. 3. 4. 5. I autogenerate the spec file from project's content and git logs. I would keep the makefile without the install target. And keep infos of installation process in the generated spec file. Can I do so or what you pointed is mandatory? The compiler flags, it sounds great to me, I'm looking for doc on this subject. Once I'll know exactly what macro defines inside the makefile, I'll use it. I hope by the end of the week. 10. I may keep only the last changelog, but it implies that lots infos might been lost. That cost me no time and no energy since it is autogenerated from git logs. But once again, let me know if shorten logs is mandatory, and I'll work on that. 12. May I add one point... I'm French and my english might be bad. Can someone check manpages? In my opinion, they are at least as important as the lib itself. Thanks a lot and see you soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
