https://bugzilla.redhat.com/show_bug.cgi?id=1843751 --- Comment #2 from Marek Polacek <mpolacek@xxxxxxxxxx> --- Thank you so much for the review! (In reply to Robert-André Mauchin 🐧 from comment #1) > - Group is not used in Fedora Done. > - Consider splitting the BR and RR one per line Done. > - You should us the %cmake macro instead of: > > export CFLAGS="${RPM_OPT_FLAGS}" > export CXXFLAGS="${RPM_OPT_FLAGS}" > # Fedora says we shouldn't put files in /usr/local/. > mkdir objdir && cd objdir && \ > cmake .. \ > -DCMAKE_INSTALL_LIBEXECDIR=%{_libexecdir} \ > -DCMAKE_INSTALL_BINDIR=%{_bindir} \ > -DCMAKE_INSTALL_DATADIR=%{_datadir} \ > -DCMAKE_BUILD_TYPE=$BUILD_TYPE && \ > > > It sets Fedora build flags and some default. (See rpm --eval "%{cmake}") Done. > - make %{?_smp_mflags} VERBOSE=1 → %make_build VERBOSE=1 > > - Release must start as 1 in Fedora Done. > Release: 1%{?dist} > > - Use a better name for your archive: Done. > Source: > https://github.com/marxin/cvise/archive/v%{version}/%{name}-%{version}.tar.gz > > - Build fails: > > DEBUG util.py:621: No matching package to install: 'python3-pebble' > > It seems python-pebble was not built on Rawhide: > https://bugzilla.redhat.com/show_bug.cgi?id=1851120 This has been fixed. Here's another version of the spec file. Anything else to fix? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
