https://bugzilla.redhat.com/show_bug.cgi?id=1845667 --- Comment #2 from Eugene A. Pivnev <ti.eugene@xxxxxxxxx> --- (In reply to Robert-André Mauchin 🐧 from comment #1) > - Group is not used in Fedora Fixed. > - Use the %{qmake_qt5} macro Fixed. > - None of this is needed anymore: > %post > %postun > %post -n libqxmledit -p /sbin/ldconfig > %postun -n libqxmledit -p /sbin/ldconfig Fixed. > - Add a comment above the patch to explain why it is needed. Give your > patch a more explicit name. Fixed. > - Shouldn't the lang files go with the binary? > %files -n libqxmledit -f %{bigname}.lang Fixed. > - In order to avoid unintentional soname bump, we recommend not globbing > the major soname version, instead be more specific: > > %{_libdir}/libQXmlEdit*.so.* Fixed. > - Please explain the breakdown of the licenses in a comment: > License: LGPLv2+ and GPLv3 and zlib Fixed. > Source0: > https://github.com/lbellonda/qxmledit/archive/%{version}.tar.gz#/%{name}- > %{version}.tar.gz > → > Source0: > https://github.com/lbellonda/qxmledit/archive/%{version}/%{name}-%{version}. > tar.gz Fixed. > - Add an explicit BR against gcc-c++ Fixed. > - The PDF is big, please split it in a separate doc noarch subpackage: Fixed. > - Split the description to stay below 80 characters per line: Fixed. ==== SPEC: https://tieugene.fedorapeople.org/rpms/qxmledit/qxmledit.spec (old SPEC: https://tieugene.fedorapeople.org/rpms/qxmledit/qxmledit-0.9.15-1.spec) SRPM: https://tieugene.fedorapeople.org/rpms/qxmledit/qxmledit-0.9.15-2.fc32.src.rpm Koji builds: - f31: https://koji.fedoraproject.org/koji/taskinfo?taskID=46643065 - f32: https://koji.fedoraproject.org/koji/taskinfo?taskID=46643067 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
