https://bugzilla.redhat.com/show_bug.cgi?id=1853780 Erich Eickmeyer <erich@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m@xxxxxxxxx | |) --- Comment #2 from Erich Eickmeyer <erich@xxxxxxxxxxxxxxxxxx> --- > - Please validate the desktop file in %install or %check > See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage > > desktop-file-validate %{_datadir}/applications/org.linuxaudio.nsm-legacy-gui.desktop Done, except you forgot the %{buildroot} part. :) > - It seems %{_bindir}/nsmd is included twice in the %files list Oops, fixed. > - Upstream mentions: > > "All files, except nsm.h kept in this fork were GPL "version 2 of the License, or (at your option) any later version." > > nsm.h is licensed under the ISC." > > > Add ISC to the license field, and add a comment explaining the license breakdown. Missed that part. Done. > - Shouldn't you provide SystemD unit file for the server part? No. The server part is not meant to run independently of the application, at least not yet afaik. New files as follows: Spec URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/01517739-new-session-manager/new-session-manager.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/01517739-new-session-manager/new-session-manager-1.3.2-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
