Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl-Inline https://bugzilla.redhat.com/show_bug.cgi?id=226262 ------- Additional Comments From panemade@xxxxxxxxx 2007-10-25 00:43 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 840f47d9b6cef39e68370faf9dceab2c Inline-0.44.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00init......ok t/01usages....ok t/02config....ok t/03errors....ok t/04create....ok t/05files.....skipped all skipped: no reason given All tests successful, 1 test skipped. Files=6, Tests=14, 11 wallclock secs ( 0.88 cusr + 0.09 csys = 0.97 CPU) make[1]: Entering directory `/builddir/build/BUILD/Inline-0.44/C' PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, '../blib/lib', '../blib/arch')" t/*.t t/00init.......ok t/01syntax.....ok t/02config.....ok t/03typemap....ok t/04perlapi....ok t/05xsmode.....ok All tests successful. Files=6, Tests=12, 13 wallclock secs ( 9.42 cusr + 1.59 csys = 11.01 CPU) + Package perl-Inline-0.44-17.fc8 -> Provides: perl(Foo::Tester) perl(Inline) = 0.44 perl(Inline::C) = 0.44 perl(Inline::C::ParseRecDescent) perl(Inline::C::ParseRegExp) perl(Inline::Foo) = 0.01 perl(Inline::MakeMaker) = 0.44 perl(Inline::denter) Requires: perl >= 0:5.005 perl(:MODULE_COMPAT_5.8.8) perl(AutoLoader) perl(Carp) perl(Config) perl(Cwd) perl(Data::Dumper) perl(ExtUtils::MakeMaker) perl(File::Spec) perl(File::Spec::Unix) perl(Inline) perl(Inline::denter) perl(base) perl(strict) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review