https://bugzilla.redhat.com/show_bug.cgi?id=1852059 --- Comment #2 from Iñaki Ucar <i.ucar86@xxxxxxxxx> --- Spec URL: https://iucar.fedorapeople.org/pkgs/flexiblas.spec SRPM URL: https://iucar.fedorapeople.org/pkgs/flexiblas-3.0.0-2.fc31.src.rpm koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=46387120 Changes: - Own provided directories: as requested. - More robust file renaming: it failed if all backends were disabled, because rename didn't find any file to rename. - Rename wrapper(64) subpackages to netlib(64): I think this is more appropriate. Also, if we change %{default_backend} to "netlib", then these packages just require themselves. - Conditionalize all external libraries, as well as the default: now I'm using %bcond_without for all the backends, so that it's easy to disable them if there is any issue with them. And the %{default_backend} changes automatically to "netlib" if OpenBLAS is not available. - Disable Blis64 on s390x, which is currently unavailable: basically, Blis doesn't detect 64-bit capabilities on that platform, and those packages are just 32-bit builds. Reported in https://bugzilla.redhat.com/show_bug.cgi?id=1852549 About the main package, I'm reluctanct to require either netlib or netlib64, because that would pull that version too for all the packages linking to the other one. There are two use cases for FlexiBLAS: 1) another package links against it, so when a user install such a package, the required FlexiBLAS bits are installed too, but the user is completely unaware of that; 2) the user knows about FlexiBLAS and actually wants to install it to use it for a local build; then the user needs to install flexiblas-devel, not flexiblas. So basically there's no use case for the main package alone. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
