[Bug 328261] Review Request: netembryo - Network abstraction library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: netembryo - Network abstraction library


https://bugzilla.redhat.com/show_bug.cgi?id=328261


panemade@xxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade@xxxxxxxxx  2007-10-25 00:13 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM But not for RPM.
  netembryo.i386: W: incoherent-version-in-changelog 0.0.4-0.2.20071011
0.0.4-0.2.20071011git.fc8
==> you can take care this at time of importing package in CVS.
+ source files match upstream.
ba732800e20247a660e14eca5386113c  netembryo-20071011git.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is small so no need of -doc subpackage.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ netembryo.pc files are present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ ldconfig scriptlets are used.
+ netembryo-0.0.4-0.2.20071011git.fc8 package ->
  Provides: libnetembryo.so.0
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4) libnetembryo.so.0 libsctp.so.1 rtld(GNU_HASH)
+ netembryo-devel-0.0.4-0.2.20071011git.fc8 package ->
  Requires: libnetembryo.so.0 netembryo = 0.0.4-0.2.20071011git pkgconfig
+ Not a GUI app.

APPROVED.






-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]