https://bugzilla.redhat.com/show_bug.cgi?id=1851405 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - You must use the Source provided in the upstream official repo: https://github.com/agievich/bee2 - Are you sure you need the static library, it is not usually shipped. - Where does the version you are using is coming from? The upstream repo didn't tag any release. - Simplify this: %{_includedir}/bee2/core/b64.h %{_includedir}/bee2/core/blob.h %{_includedir}/bee2/core/dec.h %{_includedir}/bee2/core/der.h %{_includedir}/bee2/core/err.h %{_includedir}/bee2/core/hex.h %{_includedir}/bee2/core/mem.h %{_includedir}/bee2/core/mt.h %{_includedir}/bee2/core/obj.h %{_includedir}/bee2/core/oid.h %{_includedir}/bee2/core/prng.h %{_includedir}/bee2/core/rng.h %{_includedir}/bee2/core/safe.h %{_includedir}/bee2/core/stack.h %{_includedir}/bee2/core/str.h %{_includedir}/bee2/core/tm.h %{_includedir}/bee2/core/u16.h %{_includedir}/bee2/core/u32.h %{_includedir}/bee2/core/u64.h %{_includedir}/bee2/core/util.h %{_includedir}/bee2/core/word.h %{_includedir}/bee2/crypto/bake.h %{_includedir}/bee2/crypto/bash.h %{_includedir}/bee2/crypto/bels.h %{_includedir}/bee2/crypto/belt.h %{_includedir}/bee2/crypto/bign.h %{_includedir}/bee2/crypto/botp.h %{_includedir}/bee2/crypto/brng.h %{_includedir}/bee2/crypto/dstu.h %{_includedir}/bee2/crypto/g12s.h %{_includedir}/bee2/crypto/pfok.h %{_includedir}/bee2/defs.h %{_includedir}/bee2/info.h %{_includedir}/bee2/math/ec.h %{_includedir}/bee2/math/ec2.h %{_includedir}/bee2/math/ecp.h %{_includedir}/bee2/math/gf2.h %{_includedir}/bee2/math/gfp.h %{_includedir}/bee2/math/pp.h %{_includedir}/bee2/math/pri.h %{_includedir}/bee2/math/qr.h %{_includedir}/bee2/math/ww.h %{_includedir}/bee2/math/zm.h %{_includedir}/bee2/math/zz.h Just use %{_includedir}/bee2/ for the whole directory. - You must install the license with %license in %files and you should install the %doc as well %files %license LICENSE %doc AUTHORS.md README.md - Don't do that: %if "%dist.%{_arch}" == ".el6.x86_64" Just use : %if 0%{?rhel} && 0%{?rhel} < 7 You shouldn't need to specify x86_64. - Same: %if %{defined fedora} Just use: %if 0%{?fedora} - I'd rather not mix Mageia and Suse stuff with Fedora's spec. Please use separate SPEC if you can. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
