https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #9 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #6) > Source0: > http://github.com/%{name}/%{name}/archive/v%{version}/%{name}-%{version}.tar. > gz Updated. > - Why does the core subpackage obsoletes the main package? Also for a > rename the Obsolete part must be fixed, to the release above the last > release of the obsoleted package. Long old gone thing, removed the Obsoletes. > - GZipping the man pages is handled by rpm, do not do it yourself: > > gzip %{buildroot}%{_mandir}/man1/$i.1 Missed it. Actually man pages are now installed automatically, so I removed the section entirely. > - This is only needed in EPEL7: > > %post core > /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : > > %postun core > if [ $1 -eq 0 ] ; then > /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null > /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : > fi > > %posttrans core > /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : > > Please put it behind a condition. Missed it, fixed. > - Do not package libtool archive. Static library are generally not > packaged, and, if really needed, must have their own static subpackage: > > %{_libdir}/libbitcoinconsensus.a > %{_libdir}/libbitcoinconsensus.la Disabled static library building and removed the local archive. > - In order to avoid unintentional soname bump, we recommend not globbing > the major SONAME version from shared library. Be more specific instead: > > %{_libdir}/libbitcoinconsensus.so.* Fixed. > - /var/lib/, {_localstatedir}/lib → use %{_sharedstatedir} > - /var/, %{_var} → use %{_localstatedir} > - /run → %{_rundir} Missed, all fixed. > - I know nothing about SELinux, I need to find another reviewer for this I will not separate the selinux policies from the main package. Many packages in the distribution require SELinux (ex. FreeIPA). It's not something that should be disabled, pretty much like the firewall. Testing now the above changes with 0.20, will post the updated src.rpm after all functional tests have run. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
