Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/show_bug.cgi?id=243576 jspaleta@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? ------- Additional Comments From jspaleta@xxxxxxxxx 2007-10-24 18:31 EST ------- The GOOD: rpmlint runs clean fits naming guidelines specfile naming good Licensing good: GPLv3+ and tag matches Copying file included in docs as required spec written in english-ese and is legible md5sum for source matches upstream location: 69bcc7a8939582ebdb806579947b316c gst-inspector-0.3.tar.gz builds noarch in mock against f7 and program runs buildrequires look sane no locales to worry about no libs installed that need ldconfig relocatable n/a no duplicate file entries owns all directories it creates clean section is good macro usage consistent no content issues no need for a docs subpackage all doc files are non-essential no need for -devel package no static libs install section looks good desktop file included for gui application. The BAD: directory ownership chain issue Need to require hicolor-icon-theme since you are installing icons in /usr/share/icons/hicolor/ need a postun section for the icon cache updating. You have the post you just need the corresponding postun as well: %postun touch --no-create %{_datadir}/icons/hicolor if [ -x %{_bindir}/gtk-update-icon-cache ]; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi The UGLY: Are you sure you want to put gst-inspector in audio/video? I would have thought this would be better in Programming menu since this isn't so much an aid to end-users but an aid to people developing gst based scripts and applications. -jef -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review