https://bugzilla.redhat.com/show_bug.cgi?id=1789854 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #14 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Don't use %define but %global: %define name ServiceReport %define version 2.2.1 %define release 1 And you shouldn't redefine name, version and release, use the header field for that - Group: is not used in Fedora - No: %define debug_package %{nil} Instead make you package noarch since it's Python stuff: BuildArch: noarch - Use Python macros: see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_macros %{python} setup.py build → %py3_build %{python} setup.py install --root=$RPM_BUILD_ROOT → %py3_install - Not needed: %defattr(-,root,root) - Use macros for directories: /usr/share/man → %{_mandir} /usr/lib/systemd/system/ → %{_unitdir} - Man pages are not to be installed with %doc: %{_mandir}/man8/* - Not needed: Requires: %{python} systemd - BR systemd-rpm-macros instead of systemd (if you need EPEL7 support put it behind a condition) - Some systemd scriptles are missing: see: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd %post %systemd_post servicereport.service %preun %systemd_preun servicereport.service %postun %systemd_postun_with_restart servicereport.service - Not needed: %doc /usr/share/doc/*, install the README.md with: %doc README.md - You should provide a COPYING file and install it with %license in %files: %license COPYING - # By default python 3 is used to build the package. Only Python 3 is available for Fedora 32 and above. If you're planning EPEL7 and Python2, use conditionals, for example %if 0%{?fedora} || 0%{?rhel} >= 7 %bcond_with python2 %bcond_without python3 %else %bcond_with python3 %bcond_without python2 %endif although I'd recommend to stick with Python3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
