Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: malaga - Programming language for modelling of language-dependent grammatical information https://bugzilla.redhat.com/show_bug.cgi?id=346121 ------- Additional Comments From vpivaini@xxxxxxxxxxxxxx 2007-10-24 16:49 EST ------- Thank you for your feedback, I've fixed some of the issues you pointed out. New spec: http://vpv.fedorapeople.org/packages/malaga.spec New SRPM: http://vpv.fedorapeople.org/packages/malaga-7.11-0.2.fc7.src.rpm (In reply to comment #1) > - Requires between subpackages from one srpm must usually be > version-release specific. Fixed. > - debuginfo must not be empty. NOT fixed. Upstream Makefile calls install -s, how do I remove it? Do I need to make a patch for it, or rather Makefile.in? Sorry to use bugzilla as a learning/discussion forum, but I couldn't get an answer from #fedora-devel either. > - For -devel package, -devel package requires %{name} and > %{name} requires lib%{name}. So "Requires: lib%{name}" is not > needed for -devel package. Fixed. > - install-info must be called on %post. Fixed. > - Please don't write empty scriptlet entry (why is %postun line > needed?) It wasn't, my error, I removed it. > - Please check if "INSTALL.txt" is really needed. It wasn't, so removed. > i.e. all documents should be moved to lib%{name} package. Done. > - The directory %{_datadir}/%{name} is not owned by any package. Fixed. > - Please remove static archive. If you mean %{_libdir}/libmalaga.a in -devel, if I remove that, rpmbuild complains and won't build the packages. How do I go around it then? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review