https://bugzilla.redhat.com/show_bug.cgi?id=1843256 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Group:, BuildRoot: are not used in Fedora - Add a comment above the patch explaining why it is needed. -Don't: rm -rf %{buildroot} - %defattr(-,root,root,-) is the default, therefore not needed. - -Ask upstream for a License file-, strike that the license is provided in doc/gpl.txt - The Source should be the official archive. Any modification must happen within the SPEC: this could be patches, but could also be a script that you join as SourceX that is used to modify the official archive. Another issue I have with your repo is that you joined the LICENSE file yourself, this is contrary to the Packaging guidelines which states that the License file must be provided by upstream and that the packager can't add it themselves. Another issue is the maintainability of the package, if you link to your repo and you fail to update it after a while, we would maybe miss new releases. - Bump to 0.6.25 - Use install -p to keep timestamps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
