https://bugzilla.redhat.com/show_bug.cgi?id=1848404 --- Comment #2 from Joe Orton <jorton@xxxxxxxxxx> --- Thanks for the feedback! I've updated the spec/srpm as follows: (In reply to Fabian Affolter from comment #1) > Just some quick comments: > > - License is GPLv2+, see > https://github.com/notroj/certwatch/blob/ > ff8ad088a780e35a9bf3d6a95e9ca8c8c5190f9a/certwatch.c#L4-L7 > - 'rm -rf $RPM_BUILD_ROOT' was made obsolete a while ago Both fixed. > - 'Source0: > https://github.com/notroj/certwatch/archive/v%{version}.tar.gz#/certwatch- > %{version}.tar.gz' could be replaced with 'Source0: > %{uel}/archive/v%{version}/%{name}-%{version}.tar.gz' I assume you mean %{url} not %{uel}, and it could, but I prefer the full URL. > - The replacement of crypto-utils seems incomplete, see > https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or- > replacing-existing-packages AFAICT this is exactly what the package does: "If a package supersedes/replaces an existing package without being a sufficiently compatible replacement as defined above, use only the Obsoletes: line from the above example." > - The cron job file should be tagged with '%config(noreplace)' in the % > files section Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
