https://bugzilla.redhat.com/show_bug.cgi?id=1849384 Aleksei Bavshin <alebastr89@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alebastr89@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Aleksei Bavshin <alebastr89@xxxxxxxxx> --- That's fast! Wasn't swappy released just a few days ago? I can do a formal review on the weekend. Meanwhile some notes I gathered from spec file and upstream build scripts. > Version: 1.0.0 Latest upstream version is 1.1.0. > BuildRequires: cairo-devel > BuildRequires: pango-devel BR: pkgconfig(cairo) BR: pkgconfig(pango) Maybe also BR: pkgconfig(gio-2.0) See corresponding section of the guidelines[1] and PR that changes gio to a proper pkgconfig dependency[2]. Also, there's an optional support for notifications which you could enable by adding BR: pkgconfig(libnotify) > Requires: fontawesome-fonts Requires might be too strong here. Fontawesome could be replaced with other symbol fonts (like Nerd Fonts) and lack of the font does not prevent application from starting. How about `Recommends: fontawesome-fonts`? Also: does this work correctly with fontawesome-fonts = 4.7.0 we have in Fedora? Upstream mentions version 5.x of the font. > %description I believe there's a rpmlint check somewhere for line width in description. Please, format this to 80 chars per line. rpmlint may show empty result on the .spec file while also displaying a full screen of errors on the .src.rpm. I recommend to run it on all source and binary packages before sending the review. Also, feel free to ignore most of spelling-error messages (except maybe British spellings, as specs supposed to be in American English). The dictionary rpmlint uses is woefully lacking. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/ [2] https://github.com/jtheoof/swappy/pull/42/files#diff-969b60ad3d206fd45c208e266ccfed38 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
