Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: compiz-manager - A wrapper script to start compiz with proper options https://bugzilla.redhat.com/show_bug.cgi?id=349621 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-10-24 10:29 EST ------- For 0.6.0-1: * %_libdir - This script is broken on 64 bits architecture. ! Note: to make this package "noarch", some effort is needed to deal with both 32 bits and 64 bits arch. * LIBGL_NVIDIA and so on.. - What happens if sover of LIBGL_NVIDIA changes? IMO, autodetection like: ----------------------------------------------------- for driver in $libdir/nvidia/libGL.so.*.xlibmesa ; do LIBGL_NVIDIA=$driver done ----------------------------------------------------- is better. * USE_EMERALD - Please explain why you want to disable emerald by default. - If you want, the comment on the above line is not correct. - And something like: ----------------------------------------------------- USE_EMERALD=${USE_EMERALD:-no} ----------------------------------------------------- is better IMO. * Dependency - It seems that this scripts uses some commands in xorg-x11-utils (this is not installed by default). - Also, adding requirement for pciutils is better (for /sbin/lspci) - glx-utils also seems needed. - Something else may be also needed. Would you check the dependency again? * Timestamp - Please use "-p" option when using "cp" or "install" command to keep timestamps. * ExcludeArch - compiz is not available on ppc64, so please write in the spec file "ExcludeArch: ppc64" even if this is noarch ref: https://www.redhat.com/archives/fedora-devel-list/2007-October/msg00262.html ? Desktop file - Is it preferable that this package provides desktop file entry? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review