[Bug 1839773] Review Request: bst-external - Additional BuildStream plugins

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1839773

Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #5 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> ---
(In reply to Artem from comment #4)
> > - Package must not depend on deprecated() packages.
> >   Note: python3-pytest4 is deprecated, you must not depend on it.
> >   See: https://docs.fedoraproject.org/en-US/packaging-
> >   guidelines/deprecating-packages/
> 
> This is look like fedora-review tool bug
> https://pagure.io/FedoraReview/issue/392

Yes, it is.

> 
> > - Package should be renamed to python-bst-external
> 
> Should this apply for this package since this is not a library?
> 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming
> > This rule does not apply to applications.

It's not a tool and not a library. Debian is prefixing it with 'python-', Arch
Linux simply call it 'bst-external'. Let's stick with 'bst-external'.

Package APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux