https://bugzilla.redhat.com/show_bug.cgi?id=1849706 --- Comment #8 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Some preliminary comments: Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ ^ We'll need to look into this. - Package contains BR: python2-devel or python3-devel ^ All packages must include BuildRequires: python3-devel (see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ - currently inaccessible due to the infra move) - Package is not relocatable. Note: Package has a "Prefix:" tag See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_relocatable_packages Please remove the following deprecated tags: - Prefix - Vendor - Group You do not need to define version and release macros. The tags themselves become macros, so you can use %{release} %{version} %{SOURCE0} etc. in the spec. Take a look at the python spec template: https://pagure.io/neuro-sig/NeuroFedora/blob/master/f/spec-templates/python.spec (This template is also available on the currently inaccessible Python packaging guidelines) - You can use the %{pypi_source} macro for SOURCE0. It takes three optional arguments: # default without arguments $ rpm -E %{pypi_source} https://files.pythonhosted.org/packages/source/%/%name/%name-%version.tar.gz # with positional arguments $ rpm -E "%{pypi_source pkgname version xz}" https://files.pythonhosted.org/packages/source/p/pkgname/pkgname-version.xz - You can replace the setup macro line with the autosetup macro https://rpm.org/user_doc/autosetup.html - In the build section, please use %{py3_build} (rpm -E %... to see the macro expansion). It applies the necessary compilation flags. - In the install section, please use %{py3_install} - clean section isn't needed anymore so can be removed. - We dont' use the INSTALLED_FILES method. We explicitly mention the files so that if the package is updated and the file list changes, the build fails to make the maintainer aware of this. Please see the template linked above to see how to list the installed files. - The spec is missing a changelog: this is required. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
