https://bugzilla.redhat.com/show_bug.cgi?id=1849568 Tom Stellard <tstellar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tstellar@xxxxxxxxxx --- Comment #3 from Tom Stellard <tstellar@xxxxxxxxxx> --- Since this project uses CMake, you should try to align the spec file with this proposal: https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds . I don't know if all the new macros exist, but you could at least adopt the convention of not cd'ing into the build directory. And also use _vpath_builddir macro for the build directory. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
