https://bugzilla.redhat.com/show_bug.cgi?id=1823151 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #6 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Missing systemD scriptlets: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd - /usr/lib/systemd/system/thinkpad-tools.service → %{_unitdir}/thinkpad-tools.service - Separate your changelog entries by a new line - Since you provide a binary, consider instead naming your package "thinkpad-tools" with no Python3 subpackage - Up to upstream, but generally configuration files are named *.conf not *.ini. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
