[Bug 1822949] Review Request: golang-github-parnurzeal-gorequest - Simplified HTTP client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1822949

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - I've got error in tests:

Testing    in: /builddir/build/BUILD/gorequest-0.2.16/_build/src
         PATH:
/builddir/build/BUILD/gorequest-0.2.16/_build/bin:/usr/lib64/ccache:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/gorequest-0.2.16/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X
github.com/parnurzeal/gorequest/version=0.2.16 -extldflags '-Wl,-z,relro
-Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: github.com/parnurzeal/gorequest
github.com/parnurzeal/gorequest
2020/06/21 14:41:49 http: Accept error: accept tcp 127.0.0.1:42743: accept4:
too many open files; retrying in 5ms
2020/06/21 14:41:49 http: Accept error: accept tcp 127.0.0.1:42743: accept4:
too many open files; retrying in 5ms
--- FAIL: TestTimeoutFunc (2.01s)
    gorequest_test.go:2091: Expected timeout in between 1000 -> 1500 ms | but
got 4907426
--- FAIL: TestCookies (0.00s)
    gorequest_test.go:2129: Cookies test request did not complete
FAIL
exit status 1
FAIL    github.com/parnurzeal/gorequest 2.405s


 Seems it's network related so maybe it can't work in Mock. Otherwise LGTM:

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux