https://bugzilla.redhat.com/show_bug.cgi?id=1848758 Andy Mender <andymenderunix@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andymenderunix@xxxxxxxxx --- Comment #1 from Andy Mender <andymenderunix@xxxxxxxxx> --- Name: libsoundio Version: 2.0.0 Release: 1%{?dist} Summary: C library for cross-platform real-time audio input and output License: MIT URL: http://libsound.io/ Source0: http://github.com/andrewrk/%{name}/archive/%{version}/%{name}-%{version}.tar.gz BuildRequires: gcc, cmake, alsa-lib-devel, jack-audio-connection-kit-devel, pulseaudio-libs-devel BuildRequires: doxygen, coreutils I think the BuildRequires should be sorted alphabetically and listed on separate lines. Also, I ran the rpm build via mock and it works, but when running it directly on a Fedora 32 host, I see this in the tests: Assertion '!m->thread || !pa_thread_is_running(m->thread) || !in_worker(m) || pa_atomic_load(&m->in_once_unlocked)' failed at pulse/thread-mainloop.c:179, function pa_threaded_mainloop_lock(). Aborting. /var/tmp/rpm-tmp.PZrqMa: line 34: 13190 Aborted (core dumped) ./overflow error: Bad exit status from /var/tmp/rpm-tmp.PZrqMa (%check) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.PZrqMa (%check) I would check via either COPR and/or Koji to see whether this builds cleanly on all supported platforms. PS I'm not an official Fedora packager yet so this is just courtesy feedback :). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
