[Bug 1821305] Review Request: zgrab2 - Application Layer Scanner

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1821305

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - Bump to 0.1.7

 - License seems co be ISC and ASL 2:0:

License:        ISC and ASL 2.0

 - There's an API mismatch:

# github.com/zmap/zgrab2
_build/src/github.com/zmap/zgrab2/utility.go:52:39: parser.ParseCommandLine
undefined (type *flags.Parser has no field or method ParseCommandLine)
/usr/lib/golang/pkg/tool/linux_amd64/buildid -w $WORK/b168/_pkg_.a # internal


Seems to be linked to zflags. 1.4.0-beta.1 has ParseCommandLine.



Zcrypto needs updating too:

# github.com/zmap/zgrab2/modules/http
_build/src/github.com/zmap/zgrab2/modules/http/scanner.go:229:31: undefined:
"github.com/zmap/zcrypto/tls".SigAndHash


After all this is updated, it works:

 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please fix the License before import.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux