Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl-XML-Simple https://bugzilla.redhat.com/show_bug.cgi?id=226291 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-24 00:25 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url f6522514032092dd0341aa26a408ad4d XML-Simple-2.17.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/0_Config........# ^M# Package Version # perl 5.8.8 # XML::Simple 2.17 # Storable 2.15 # XML::Parser 2.34 # XML::SAX 0.16 # XML::NamespaceSupport 1.09 # XML::SAX::PurePerl 0.92 # XML::LibXML::SAX::Parser 1.62 # XML::LibXML::SAX 1.62 (default parser) ok t/1_XMLin.........ok t/2_XMLout........ok t/3_Storable......ok t/4_MemShare......ok t/5_MemCopy.......ok t/6_ObjIntf.......ok t/7_SaxStuff......ok t/8_Namespaces....ok t/9_Strict........ok t/A_XMLParser.....ok t/B_Hooks.........ok All tests successful. Files=12, Tests=485, 15 wallclock secs ( 3.22 cusr + 0.29 csys = 3.51 CPU) + Package perl-XML-Simple-2.17-2.fc8 -> Provides: perl(XML::Simple) = 2.17 perl(XML::Simple::FAQ) Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Exporter) perl(XML::Parser) perl(strict) perl(utf8) perl(vars) + Not a GUI app APPROVED. You can CLOSE this review as reviewed package is already in CVS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review