[Bug 1821189] Package Review: Snakemake - Workflow management system to create reproducible and scalable data analyses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1821189



--- Comment #4 from Aniket Pradhan <aniketpradhan1999@xxxxxxxxx> ---
Hello Hirotaka

Finally got some time to boot up my Fedora system, so I spent some time fixing
this :D



> - Source0
>   Please make sure the source code url is available.
>   ```
>   $ wget
> https://github.com/aflc/snakemake/archive/v5.12.3/snakemake-5.12.3.tar.gz
>   --2020-06-05 22:19:21-- 
> https://github.com/aflc/snakemake/archive/v5.12.3/snakemake-5.12.3.tar.gz
>   Resolving github.com (github.com)... 52.192.72.89
>   Connecting to github.com (github.com)|52.192.72.89|:443... connected.
>   HTTP request sent, awaiting response... 404 Not Found
>   2020-06-05 22:19:21 ERROR 404: Not Found.
>   ```
>   You can use the %pypi_source macro. Please see:

Fixed the source to upstream release


> - Dependencies
>   Please check dependent packages. Some packages don't seem to exist.
>   ```
>   $ sudo dnf install -y
> ~/rpmbuild/RPMS/x86_64/snakemake-5.12.3-1.fc33.x86_64.rpm 
>   Last metadata expiration check: 0:49:45 ago on Fri 05 Jun 2020 10:06:39 PM
> UTC.
>   Error: 
>    Problem: conflicting requests
>     - nothing provides python3.9dist(datrie) needed by
> snakemake-5.12.3-1.fc33.x86_64
>     - nothing provides python3.9dist(ratelimiter) needed by
> snakemake-5.12.3-1.fc33.x86_64
>     - nothing provides python3.9dist(toposort) needed by
> snakemake-5.12.3-1.fc33.x86_64
>   ```
>   You can see the list of dependencies:
>   $ rpm -qp --requires  snakemake-5.12.3-1.fc33.x86_64.rpm

I don't see these deps coming up now, so I guess it has been resolved with the
new release.


> - Version
>   Please update the version if newer version exists.

Updated.


> - BuildRequires
>   "gcc-c++" is not needed if you don't build c/c++ applications.
>   "python-unversioned-command" is probably not needed because packages on
> Fedora
>   doesn't directly use /usr/bin/python.

You're right. I had used my old spec as a template and must have overlooked
gcc-c++. Removed it.
python-unversioned-command is needed because a test calls `python` as a
subprocess.


> - Package installs properly.
>   Note: Installation errors (see attachment)
>   See: https://docs.fedoraproject.org/en-US/packaging-guidelines/

It's installing fine now. Here's the koji scratch build [0].

[0]: https://koji.fedoraproject.org/koji/taskinfo?taskID=45855832


> - Packages MUST NOT have dependencies (either build-time or runtime) on
>   packages named with the unversioned python- prefix unless no properly
>   versioned package exists. Dependencies on Python packages instead MUST
>   use names beginning with python2- or python3- as appropriate.
>   Note: Unversionned Python dependency found.
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/Python/#_dependencies

I am quite unsure of what dependencies you're referring to here. Do you mean:
- rpmlib(CompressedFileNames) <= 3.0.4-1
- rpmlib(FileDigests) <= 4.6.0-1
These two deps are generated automatically by RPM I guess.



I have updated the spec and the SRPM on the previous links:

Spec: https://major.fedorapeople.org/snakemake/snakemake.spec
SRPM: https://major.fedorapeople.org/snakemake/snakemake-5.19.3-1.fc32.src.rpm

Thanks a lot for holding up for me... It has been long since I am using Fedora,
mainly due to work :P


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux