[Bug 1835452] Review Request: mlxbf-bootctl - Bootloader control for Mellanox BlueField

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1835452

Honggang LI <honli@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(mschmidt@redhat.c
                   |                            |om)



--- Comment #8 from Honggang LI <honli@xxxxxxxxxx> ---
(In reply to Spencer Lingard from comment #6)
> Spec URL:
> https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bootctl/
> fedora-rawhide-aarch64/01476093-mlxbf-bootctl/mlxbf-bootctl.spec

 27 %build
 28 %make_build

Need to setup the CFLAGS. Please insert %set_build_flags between line 27 and
28. see
https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md



https://kojipkgs.fedoraproject.org//work/tasks/5292/45835292/build.log

+ cd mlxbf-bootctl-1.1
+ /usr/bin/make -O -j5 V=1 VERBOSE=1
cc -O2 -g -std=gnu99 -Werror -Wall -Wshadow -Wuninitialized -Wstrict-overflow
-Wundef -Wold-style-definition -Wwrite-strings -MD -MP -c -o mlxbf-bootctl.o
mlxbf-bootctl.c
cc -Wl,--fatal-warnings -o mlxbf-bootctl mlxbf-bootctl.o

@Michal
 Could you please have a look? I'm almost OK with the spec file. I had checked
'fedora-review' result for
this request. It looks almost good.

 If you are OK with the spec file. I will set the 'fedora-review+' flag, and
post the fedora-review result.txt.

Thanks


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux