[Bug 1821809] Review Request: golang-github-sourcemap - Source maps consumer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1821809



--- Comment #1 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> ---
Hello Fabian,

I'm not sure, but no tests seem not to have run in %check. The spec file looks
good. If you know anything, please tell me.

Here is an excerpt of my rpmbuild log. 
```
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.Z0UYtg
+ umask 022
+ cd /home/vagrant/rpmbuild/BUILD
+ cd sourcemap-2.1.3
+ LDFLAGS='-X github.com/go-sourcemap/sourcemap/version=2.1.3'
+ GO_TEST_FLAGS='-buildmode pie -compiler gc'
+ GO_TEST_EXT_LD_FLAGS='-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld '
+ go-rpm-integration check -i github.com/go-sourcemap/sourcemap -b
/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build/bin -s
/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build -V 2.1.3-1.fc33 -p
/home/vagrant/rpmbuild/BUILDROOT/golang-github-sourcemap-2.1.3-1.fc33.x86_64 -g
/usr/share/gocode -r '.*example.*'
Testing    in: /home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build/src
         PATH:
/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build/bin:/home/vagrant/.local/bin:/home/vagrant/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin
       GOPATH:
/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X
github.com/go-sourcemap/sourcemap/version=2.1.3 -extldflags '-Wl,-z,relro
-Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: github.com/go-sourcemap/sourcemap
+ RPM_EC=0
++ jobs -p
+ exit 0
```

I find this upstream prepares tests and I could run.
```
[vagrant@localhost sourcemap-2.1.3]$ export
GOPATH=/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build:/usr/share/gocode
[vagrant@localhost sourcemap-2.1.3]$ make
go test ./...
ok      _/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3   0.315s
ok      _/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/internal/base64vlq       
0.002s
go test ./... -short -race
ok      _/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3   0.373s
ok      _/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/internal/base64vlq       
0.029s
go vet
```

Thanks in advance,
Hirotaka Wakabayashi


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux