https://bugzilla.redhat.com/show_bug.cgi?id=1844850 Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #17 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> --- Three little things left to do before the first build, mentioned in detail in the template text: 1. Requires: shared-mime-info 2. %license in antimicroX-libantilib-devel 3. File a blocking bug for the ExcludeArch Everything else seems fine, package is approved! Nicely done Gergely! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [!]: License file installed when any subpackage combination is installed. Since antimicroX-libantilib-devel requires antimicroX-libantilib, you can just add it to the antimicroX-libantilib %files section: %files %{libname} %license LICENSE %{_libdir}/%{libname}.so.1 [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/mime/packages, /usr/share/mime Add "Requires: shared-mime-info" [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. You need to file a bug once the package is approved and also mark it as blocking https://bugzilla.redhat.com/show_bug.cgi?id=F-ExcludeArch-ARM Once that bug is files, add the bug number to the spec file in a comment next to the ExcludeArch tag. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in antimicroX-libantilib , antimicroX-libantilib-devel [?]: Package functions as described. Don't have a gamepad anymore… [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: Package should compile and build into binary rpms on all supported architectures. Same as above. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: antimicroX-3.0-1.20200617gitc6d79.fc32.x86_64.rpm antimicroX-libantilib-3.0-1.20200617gitc6d79.fc32.x86_64.rpm antimicroX-libantilib-devel-3.0-1.20200617gitc6d79.fc32.x86_64.rpm antimicroX-debuginfo-3.0-1.20200617gitc6d79.fc32.x86_64.rpm antimicroX-debugsource-3.0-1.20200617gitc6d79.fc32.x86_64.rpm antimicroX-3.0-1.20200617gitc6d79.fc32.src.rpm antimicroX.x86_64: W: spelling-error Summary(en_US) gamepad -> game pad, game-pad, gamed antimicroX.x86_64: W: spelling-error %description -l en_US gamepad -> game pad, game-pad, gamed antimicroX-libantilib.x86_64: W: summary-not-capitalized C antimicroX libraries antimicroX-libantilib.x86_64: W: no-documentation antimicroX-libantilib-devel.x86_64: W: no-documentation antimicroX.src: W: spelling-error Summary(en_US) gamepad -> game pad, game-pad, gamed antimicroX.src: W: spelling-error %description -l en_US gamepad -> game pad, game-pad, gamed 6 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (debuginfo) ------------------- Checking: antimicroX-debuginfo-3.0-1.20200617gitc6d79.fc32.x86_64.rpm antimicroX-libantilib-debuginfo-3.0-1.20200617gitc6d79.fc32.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. antimicroX-debugsource.x86_64: W: invalid-url URL: https://github.com/juliagoda/antimicroX <urlopen error [Errno -2] Name or service not known> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. antimicroX-libantilib-debuginfo.x86_64: W: invalid-url URL: https://github.com/juliagoda/antimicroX <urlopen error [Errno -2] Name or service not known> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. antimicroX-libantilib-devel.x86_64: W: invalid-url URL: https://github.com/juliagoda/antimicroX <urlopen error [Errno -2] Name or service not known> antimicroX-libantilib-devel.x86_64: W: no-documentation warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. antimicroX-libantilib.x86_64: W: summary-not-capitalized C antimicroX libraries antimicroX-libantilib.x86_64: W: invalid-url URL: https://github.com/juliagoda/antimicroX <urlopen error [Errno -2] Name or service not known> antimicroX-libantilib.x86_64: W: no-documentation warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. antimicroX.x86_64: W: spelling-error Summary(en_US) gamepad -> game pad, game-pad, gamed antimicroX.x86_64: W: spelling-error %description -l en_US gamepad -> game pad, game-pad, gamed antimicroX.x86_64: W: invalid-url URL: https://github.com/juliagoda/antimicroX <urlopen error [Errno -2] Name or service not known> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. antimicroX-debuginfo.x86_64: W: invalid-url URL: https://github.com/juliagoda/antimicroX <urlopen error [Errno -2] Name or service not known> 6 packages and 0 specfiles checked; 0 errors, 11 warnings. Source checksums ---------------- https://github.com/juliagoda/antimicroX/archive/c6d79008dfb9fa393eb467ae17201fc693f19f47/antimicroX-c6d79008dfb9fa393eb467ae17201fc693f19f47.tar.gz : CHECKSUM(SHA256) this package : b998046d34b050efc56e77a5e24ea102e690306d139eda92affe580eb27f6df9 CHECKSUM(SHA256) upstream package : b998046d34b050efc56e77a5e24ea102e690306d139eda92affe580eb27f6df9 Requires -------- antimicroX (rpmlib, GLIBC filtered): antimicroX-libantilib(x86-64) hicolor-icon-theme libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.14)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libX11.so.6()(64bit) libantilib.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) shared-mime-info antimicroX-libantilib (rpmlib, GLIBC filtered): libQt5Concurrent.so.5()(64bit) libQt5Concurrent.so.5(Qt_5)(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.14)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5X11Extras.so.5()(64bit) libQt5X11Extras.so.5(Qt_5)(64bit) libSDL2-2.0.so.0()(64bit) libX11.so.6()(64bit) libXi.so.6()(64bit) libXtst.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) antimicroX-libantilib-devel (rpmlib, GLIBC filtered): antimicroX-libantilib(x86-64) libantilib.so.1()(64bit) antimicroX-debuginfo (rpmlib, GLIBC filtered): antimicroX-debugsource (rpmlib, GLIBC filtered): Provides -------- antimicroX: antimicroX antimicroX(x86-64) application() application(com.github.juliagoda.antimicroX.desktop) metainfo() metainfo(com.github.juliagoda.antimicroX.appdata.xml) mimehandler(application/x-amgp) antimicroX-libantilib: antimicroX-libantilib antimicroX-libantilib(x86-64) libantilib.so.1()(64bit) antimicroX-libantilib-devel: antimicroX-libantilib-devel antimicroX-libantilib-devel(x86-64) antimicroX-debuginfo: antimicroX-debuginfo antimicroX-debuginfo(x86-64) debuginfo(build-id) antimicroX-debugsource: antimicroX-debugsource antimicroX-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review --prebuilt -rn antimicroX-3.0-1.20200617gitc6d79.fc32.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Python, fonts, R, SugarActivity, Perl, Java, PHP, Haskell, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
