https://bugzilla.redhat.com/show_bug.cgi?id=1848027 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- The Url and Source0 addresses are Ok. A Source0 archive (SHA-256: 4e3d1dfd095b2123268586bb06b86929ea571388d4e941acccbdcda1e108ef28) is original. Ok. Summary verified from lib/SQL/Abstract/Classic.pm. Ok. Description verified from lib/SQL/Abstract/Classic.pm. Ok. License verified from lib/SQL/Abstract/Classic.pm and Makefile.PL. Ok. No XS code, noarch BuildArch is Ok. Test::Deep is not used. Ok. MRO::Compat is not used with recent perl. Ok. All tests pass. Ok. $ rpmlint perl-SQL-Abstract-Classic.spec ../SRPMS/perl-SQL-Abstract-Classic-1.91-1.fc33.src.rpm ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm sh: /usr/bin/python2: No such file or directory 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm drwxr-xr-x 2 root root 0 Jun 17 17:17 /usr/share/doc/perl-SQL-Abstract-Classic -rw-r--r-- 1 root root 16163 Oct 17 2019 /usr/share/doc/perl-SQL-Abstract-Classic/Changes -rw-r--r-- 1 root root 17109 Jun 17 17:16 /usr/share/man/man3/SQL::Abstract::Classic.3pm.gz -rw-r--r-- 1 root root 2284 Jun 17 17:16 /usr/share/man/man3/SQL::Abstract::Util.3pm.gz drwxr-xr-x 2 root root 0 Jun 17 17:16 /usr/share/perl5/vendor_perl/SQL drwxr-xr-x 2 root root 0 Jun 17 17:16 /usr/share/perl5/vendor_perl/SQL/Abstract -rw-r--r-- 1 root root 89689 Oct 17 2019 /usr/share/perl5/vendor_perl/SQL/Abstract/Classic.pm -rw-r--r-- 1 root root 4985 Oct 17 2019 /usr/share/perl5/vendor_perl/SQL/Abstract/Util.pm The file permissions and a layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.3) 1 perl(Carp) 1 perl(Exporter) >= 5.57 1 perl(List::Util) 1 perl(mro) 1 perl(Scalar::Util) 1 perl(SQL::Abstract) >= 1.79 1 perl(SQL::Abstract::Util) 1 perl(strict) 1 perl(Text::Balanced) >= 2.00 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 FIX: Drop a run-time dependency on SQL::Abstract. It's not used anywhere. Probably a remnant of forking from SQL::Abstract. I can see that it's there because of a version of SQL::Abstract::Test. But SQL::Abstract::Test is used only when the tests are performed. $ rpm -q --provides -p ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm | sort -f | uniq -c 1 perl(SQL::Abstract::Classic) = 1.91 1 perl(SQL::Abstract::Util) 1 perl-SQL-Abstract-Classic = 1.91-1.fc33 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm Binary dependencies are resolvable. Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the 'FIX' item before building the package. Resolution: Package APPROVED. The package builds in Fedora 33 (https://koji.fedoraproject.org/koji/taskinfo?taskID=45828264). OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
