https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #13 from Richard W.M. Jones <rjones@xxxxxxxxxx> --- Nearly there, we're getting into nitpicking now: (1) Please fix the whitespace in: Requires:libvirt-python (2) BuildRequires: mock is listed twice. (3) It would be nice if the %check section came after the %install section. This reflects the order in which rpmbuild runs the sections: %prep -> %build -> %install -> %check (4) You said in your answer to Miro here: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/IVTYKIOMCQPMW5SJZZ7LKUQ5SMVIULEM/ that you would update the doc. Does this package include the updated documentation with this change? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
