https://bugzilla.redhat.com/show_bug.cgi?id=1847058 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- > %{!?_httpd_apxs: %{expand: %%global _httpd_apxs %%{_sbindir}/apxs}} > %{!?_httpd_mmn: %{expand: %%global _httpd_mmn %%(cat %{_includedir}/httpd/.mmn || echo 0-0)}} These don't seem to be needed, they are defined and provided by the httpd-devel package, could you please remove them? > Source0: https://github.com/downloads/archiecobbs/mod-authn-otp/mod-authn-otp-%{version}.tar.gz This URL is not valid. It seems something like works: > Source0: %{url}/archive/%{version}/mod-authn-otp-%{version}.tar.gz > %setup -q -n mod-authn-otp-%{version} Please consider using "%autosetup -n mod-authn-otp-%{version}" > make %{?_smp_mflags} CFLAGS="%{optflags} -fPIE" Please use '%make_build' in place of "make %{?_smp_mflags}", and instead of "%{optflags}", please consider using "%{build_cflags}". > %doc CHANGES LICENSE README* users.sample Please break out "LICENSE" to %license, like so: > %doc CHANGES README* users.sample > %license LICENSE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
