Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-channel-symfony - Adds symfony project channel to PEAR https://bugzilla.redhat.com/show_bug.cgi?id=337791 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-10-23 20:17 EST ------- There's not much to these channel packages. rpmlint says: php-channel-symfony.noarch: W: no-documentation which is true, but not a blocker. I'm not sure your URL: is correct. Shouldn't it point to symfony-project.com? phing.info seems to be the page for a different project. I'm not even sure the channel.xml contains copyrightable content, but given that the actual symfony-project software is all under the MIT license, are you sure that LGPLv2 is proper? Where do you find that documented? * source file matches upstream: b5e1ea8f15922ce174428fc9b264a08434a81ee97a327fd84692bf042a218533 channel.xml * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. ? license field matches the actual license. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint output is OK. * final provides and requires are sane: php-channel(pear.symfony-project.com) php-channel-symfony = 1.0.0-1.fc8 = /bin/sh /usr/bin/pear php-cli php-pear(PEAR) * doesn't own any directories it shouldn't. * no duplicates in %files (only one file!) * file permissions are appropriate. * scriptlets are OK (PEAR channel registration) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review