https://bugzilla.redhat.com/show_bug.cgi?id=1844643 Gergely Gombos <gombosg@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(alex.ploumistos@g | |mail.com) --- Comment #1 from Gergely Gombos <gombosg@xxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Qwt License 1.0 should be "LGPLv2+ with exceptions" according to the https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses (Bundled COPYING file is LGPLv2.1 with exceptions.) - Feedback needed: qt5-qtbase looks to be required for this package to function. It owns %{_qt5_docdir}. If it is required anyway, then you "should not" own that directory. How do you see this? - You could set "master" to e.g. a "branch" macro, it is used everywhere in the specfile, and it is not a static value. - Maybe you could add to the -doc description that it's HTML documentation? Optional. - Note, I haven't tested the actual software API, only the packaging. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. /usr/lib64/qt5/plugins/designer/libqwt5_designer_plugin.so is not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/doc/qt5(qt5-qtbase, qwt-doc), /usr/share/doc/qt5/html(qwt- doc) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: qwt5-qt5-5.2.3a-3.20190819giteeacc44.fc33.x86_64.rpm qwt5-qt5-devel-5.2.3a-3.20190819giteeacc44.fc33.x86_64.rpm qwt5-qt5-doc-5.2.3a-3.20190819giteeacc44.fc33.noarch.rpm qwt5-qt5-debuginfo-5.2.3a-3.20190819giteeacc44.fc33.x86_64.rpm qwt5-qt5-debugsource-5.2.3a-3.20190819giteeacc44.fc33.x86_64.rpm qwt5-qt5-5.2.3a-3.20190819giteeacc44.fc33.src.rpm qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtLinearScaleEngine.qt5.3.gz 38: warning: numeric expression expected (got `f') qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtLog10ScaleEngine.qt5.3.gz 41: warning: numeric expression expected (got `f') qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtScaleDraw.qt5.3.gz 478: a newline character is not allowed in an escape name qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtScaleDraw.qt5.3.gz 479: a newline character is not allowed in an escape name qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtScaleDraw.qt5.3.gz 480: a newline character is not allowed in an escape name qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtScaleDraw.qt5.3.gz 481: a newline character is not allowed in an escape name qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtinstall.qt5.3.gz 52: warning: macro `man' not defined qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtinstall.qt5.3.gz 108: warning: macro `Programs->Qt' not defined qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtlicense.qt5.3.gz 157: warning: macro `work' not defined qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtlicense.qt5.3.gz 466: warning: macro `any' not defined qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtlicense.qt5.3.gz 517: warning: macro `copyright'' not defined 6 packages and 0 specfiles checked; 0 errors, 11 warnings. Rpmlint (debuginfo) ------------------- Checking: qwt5-qt5-debuginfo-5.2.3a-3.20190819giteeacc44.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. qwt5-qt5-debugsource.x86_64: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. qwt5-qt5-devel.x86_64: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. qwt5-qt5.x86_64: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. qwt5-qt5-doc.noarch: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. qwt5-qt5-debuginfo.x86_64: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known> 5 packages and 0 specfiles checked; 0 errors, 5 warnings. Unversioned so-files -------------------- qwt5-qt5: /usr/lib64/qt5/plugins/designer/libqwt5_designer_plugin.so Source checksums ---------------- https://github.com/gbm19/qwt5-qt5/archive/master/qwt5-qt5-master.tar.gz : CHECKSUM(SHA256) this package : ba9c1e53f04059dfa8dfa35ce22ccede1c2baff26b91700b3b094993079d6108 CHECKSUM(SHA256) upstream package : ba9c1e53f04059dfa8dfa35ce22ccede1c2baff26b91700b3b094993079d6108 Requires -------- qwt5-qt5 (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.14)(64bit) libQt5Designer.so.5()(64bit) libQt5Designer.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libqwt5-qt5.so.5()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) qwt5-qt5-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libqwt5-qt5.so.5()(64bit) pkgconfig(Qt5Gui) pkgconfig(Qt5PrintSupport) pkgconfig(Qt5Svg) pkgconfig(Qt5Widgets) qwt5-qt5(x86-64) qwt5-qt5-doc (rpmlib, GLIBC filtered): qwt5-qt5-debuginfo (rpmlib, GLIBC filtered): qwt5-qt5-debugsource (rpmlib, GLIBC filtered): Provides -------- qwt5-qt5: libqwt5-qt5.so.5()(64bit) libqwt5_designer_plugin.so()(64bit) qwt5-qt5 qwt5-qt5(x86-64) qwt5-qt5-devel: pkgconfig(qwt5-qt5) qwt5-qt5-devel qwt5-qt5-devel(x86-64) qwt5-qt5-doc: qwt5-qt5-doc qwt5-qt5-debuginfo: debuginfo(build-id) qwt5-qt5-debuginfo qwt5-qt5-debuginfo(x86-64) qwt5-qt5-debugsource: qwt5-qt5-debugsource qwt5-qt5-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1844643 -v Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Perl, Python, Ocaml, Haskell, Java, R, fonts, PHP, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
