https://bugzilla.redhat.com/show_bug.cgi?id=1835452 Honggang LI <honli@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(spencer@mellanox. | |com) --- Comment #2 from Honggang LI <honli@xxxxxxxxxx> --- 1 Name: mlxbf-bootctl 2 Version: 1.1 3 %{!?_release: %define _release 4} 4 Release: %{_release}%{?dist} Please delete line 3, and replace "%{_release}" with 4 for line 4. 5 Summary: Mellanox BlueField boot partition management utility 6 7 License: BSD 8 Url: https://github.com/Mellanox/mlxbf-bootctl 9 Source: mlxbf-bootctl-1.1.tar.gz 10 11 ExclusiveArch: aarch64 Need a comment for "ExclusiveArch", see https://fedoraproject.org/wiki/Packaging:ReviewGuidelines 12 13 BuildRequires: binutils 14 BuildRequires: gcc line 13 should be deleted, as gcc requires binutils. $ rpm -qR gcc | grep binutils binutils >= 2.31 15 16 %description 17 Access to all the boot partition management is via a program shipped 18 with the BlueField software called "mlxbf-bootctl". I have no idea what is main function or feature of this package after read this '%description' section. Please improve it. 19 20 %prep 21 %setup -q -n mlxbf-bootctl-1.1 "%setup -q" should be enough, in case 1) top directory name was in format "%{name}-%{version}/" 2) tarball name was in format "%{name}-%{version}.XXX" 22 23 %build 24 %make_build 25 26 %install 27 %make_install 28 %{__install} -d %{buildroot}%{_mandir}/man8 29 %{__install} -m 0644 mlxbf-bootctl.8 %{buildroot}%{_mandir}/man8 30 31 %files 32 %defattr(-, root, root) line 32 is unnecessary, please remove it. 33 /sbin/* should install programs in %{_sbindir}, and use %{_sbindir}/XXX, XXX is the program name. 34 %{_mandir}/man8/mlxbf-bootctl.8.gz 35 36 %license LICENSE 37 %doc mlxbf-bootctl.txt 38 39 %changelog 40 * Wed Jun 10 2020 Spencer Lingard <spencer@xxxxxxxxxxxx> 1.1-4 41 (none) 42 43 * Tue May 12 2020 Spencer Lingard <spencer@xxxxxxxxxxxx> 1.1-3 44 (none) line 41 and 44 are unnecessary, should be deleted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
