https://bugzilla.redhat.com/show_bug.cgi?id=1835852 --- Comment #10 from Sandro Mani <manisandro@xxxxxxxxx> --- > #{?mingw_debug_package} Should probably uncommented? Or otherwise given a reason for the comment. > %mingw_make -j12 %{?_smp_mflags}, or just %mingw_make_build > %mingw_make_install DESTDIR=%{buildroot} You don't need to specify DESTDIR, %mingw_make_install does it already > %{mingw32_bindir}/libportaudio.lib > %{mingw64_bindir}/libportaudio.lib What are these? Shouldn't they be dll.a files, and placed in %{mingwXX_libdir}? Rest looks good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
