https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #4 from ycollet <ycollette.nospam@xxxxxxx> --- Hello, Thanks for the review. I totally forgot to replace %setup by %autosetup, sorry. I was focused on the fix wrt the debug package generation. I removed the Group tag and I switch from %__install to install. I corrected the desktop-file-install command. I also removed the %post and other sections. I've got this sections by digging years ago in https://src.fedoraproject.org/. But I didn't notice that the usage changed. I changed the Source0 line to download directly the release from the github page. I changed the summary and descriptions. I also checked the length of lines so as to respect the 80 symbols limit. The Obsolete line is removed. And I added the files in %doc and %license (I totally forgot to add these file). I also added a check on fedora version. For Fedora 32, I use all the security flags. For Fedora 31 and below, I remove the -fcf-protection flag because I still use this spec file to build jamulus for Fedora 30 and 31. My main machine is still on Fedora 30. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
