https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #7 from lnie <lnie@xxxxxxxxxx> --- >In the section %if %{with_python3} ... %else ... %endif that defines BuildRequires and Requires, > it is better to factor out the common BRs/Rs, yeah,much clearer now,thanks. >Is it really the case that qemu-img is only required if using >Python 3, or is that a mistake revealed by the refactoring? Sorry,I shouldn't overlook python2 part even if we don't use it in Fedora, won't make this kind of mistake again. >There is documentation supplied upstream but it is not packaged. You mean I should package the pdf ,right? >The source URL is indeed wrong - please fix it. I can wget https://gitlab.com/libvirt/libvirt-test-API/-/archive/1.0/libvirt-test-api-1.0.tar.gz manually, and I can open https://gitlab.com/libvirt/libvirt-test-API successfully,will try to work it out. > Please fix the other things while we're waiting for a > response from the Fedora community. Sure,thanks a lot for your review:) > Lili, could you please also see Miro's question here: > https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/3UL6WXFP4JHUJRH6BUT5XSWLKTTDT5XE/ Sure thing,replied. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
