https://bugzilla.redhat.com/show_bug.cgi?id=1830712 --- Comment #10 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> --- E.g., what my pedantic eyes catch is the inconsistent alignment here: BuildRequires: desktop-file-utils BuildRequires: libappstream-glib BuildRequires: extra-cmake-modules BuildRequires: cmake(Qt5Core) >= 5.9.0 … (The first 2 BuildRequires have 1 space after the colon, all the others have 2 spaces.) That is not something I would fail a review for (because the users of the package won't even notice), but if I were the maintainer of the package, I would have the instant urge to fix this. :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
